Skip to content

Fix the Products breadcrumb link on product pages - #21

Closed
miharp wants to merge 1 commit into
OpenVoxProject:mainfrom
miharp:fix/product-breadcrumb-link
Closed

miharp wants to merge 1 commit into
OpenVoxProject:mainfrom
miharp:fix/product-breadcrumb-link

Conversation

@miharp

@miharp miharp commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Scope: this only affects the site when it runs from the container image (for example a local docker run preview). The live GitHub Pages site is not affected.

The "Products" breadcrumb on every product page links to /products. GitHub Pages resolves that to products.html, so it works in production. The repo's nginx container does not, so the same click returns a 403 there. This points the breadcrumb at /products.html, which works in both.

The problem

_layouts/product.html was the only place on the site with an extensionless internal link. The products collection is written to /products/*.html, so /products is also a directory, and that directory has no index page.

Path GitHub Pages (live) nginx container
/products 200 301 to /products/, then 403
/products.html 200 200

html-proofer did not catch this because the products directory exists in the built site.

The fix

One line: the breadcrumb now uses /products.html, the same target as the "All Products" button in the same layout and the header and footer links.

Testing

  • Reproduced the 403 by serving the built site with nginxinc/nginx-unprivileged:alpine and the repo's nginx.conf.
  • After the change, the breadcrumb on the product pages returns 200 under the same setup.
  • Confirmed https://openvoxproject.github.io/products returns 200 today, so nothing changes for the live site.
  • htmlproofer passes on the rebuilt site, and no extensionless internal links remain in the output.

Assisted by Claude.

The product layout's breadcrumb linked to /products, the only
extensionless internal link on the site. The products collection is
written to /products/*.html, so /products is also a directory with no
index page. Under the repo's nginx config the link redirects to
/products/ and returns 403.

Point it at /products.html, matching the "All Products" link in the
same layout and the header and footer navigation.

html-proofer did not flag this because the directory exists on disk.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Michael Harp <mike@mikeharp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant